feat: Added ariaHidden to Modal component Props. #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy Preview for react-daisyui processing.
|
yosipy
changed the title
benjitrosch
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
@yosipy thanks for catching this and submitting a PR. LGTM!
benjitrosch
pushed a commit
that referenced
this pull request
Aug 28, 2024
benjitrosch
pushed a commit
that referenced
this pull request
Aug 28, 2024
* feat(Modal): added ariaHidden to Modal component Props. (#456) * fix(Modal): fixed Props type to use DialogHTMLAttributes * refactor: remove ModalLegacyProps as it is not used
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If elements that can receive focus are to be included in Modal's children, they must be
aria-hidden="false". However, there is no option to specify aria-hidden, so I would like to add it.If using
props.backdrop, the user would setprops.open=undefined. Therefore, the ability to specify aria-hidden independent of the value ofprops.openwould be beneficial.The addition of this feature does not affect existing operation. When
props.ariaHiddenis undefined, the behavior is the same as before.mdn states the following: