-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
side-by-side xml diff #22
Conversation
fixes #12
@bertfrees: Both locally and on travis this build fails; could you check out this branch and |
blocked on daisy/xproc-maven-plugin/pull/8 |
I managed to build it. Building the next branch of xproc-maven-plugin is not enough, you also need to prevent maven-invoker-plugin from downloading the old version from Sonatype. In <pluginRepository>
<id>local.central</id>
<url>@localRepositoryUrl@</url>
<releases>
<enabled>true</enabled>
</releases>
<snapshots>
<enabled>true</enabled>
</snapshots>
</pluginRepository> and I had to disable <snapshots>
<enabled>false</enabled>
</snapshots> Just removing the |
(also some POM cleanup)
So this will build successfully when daisy/xproc-maven-plugin#8 is merged? |
Yes. Well does it work for you locally? I see you committed the above mentioned change but I guess that will break Travis. |
It works locally, yes. Should I not have committed the above mentioned change? |
It was kind of a hack to work around maven-invoker-plugin's funny behaviour. Once you can depend on a released version of xproc-maven-plugin I'd remove the pluginRepositories section completely. |
fixes #12