Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [DO NOT MERGE] v4.1.4 diff #4

Closed
wants to merge 40 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
da2deae
changed package name to denote DAISY fork
danielweck Jan 19, 2021
bdcf58d
initial patching (scripts/axe-patch-is-aria-role-allowed.js scripts/a…
danielweck Jan 19, 2021
5830ea9
Mocha fast bail
danielweck Jan 19, 2021
8b3740d
semver is same as Axe Core but with DAISY addon suffix. Also added NP…
danielweck Jan 19, 2021
723b98a
semver is reflected in auto-generated doc
danielweck Jan 19, 2021
2e70235
added unit tests for implicit/explicit and DPUB role parsing
danielweck Jan 19, 2021
4ce706d
Scoped NPM package name, and files selection for NPM publish
danielweck Jan 19, 2021
1c9a0b2
NPM public publish
danielweck Jan 19, 2021
6590f7f
Merge branch 'v4.1.1_DAISY' into v4.1.2_DAISY
danielweck Feb 16, 2021
ea67596
rules MD
danielweck Feb 16, 2021
e04a57a
ignore epub:type
danielweck Feb 18, 2021
af3e209
Merge branch 'v4.1.2_DAISY' into v4.1.3_DAISY
danielweck Mar 10, 2021
161d97e
Unit tests require package.json version without canary or arbitrary e…
danielweck Mar 10, 2021
2a6ab7e
landmark-one-main now with page-no-duplicate-main in addition to page…
danielweck Mar 10, 2021
dae726f
doc: landmark-one-main now with page-no-duplicate-main in addition to…
danielweck Mar 10, 2021
2b5bb2d
intermediary commit (Axe hook seems to stash things in the working co…
danielweck Mar 10, 2021
6121f22
main element and div with role
danielweck Mar 10, 2021
10be613
added unit test for landmark-no-duplicate-main to pass content with n…
danielweck Mar 10, 2021
72707cf
matching-aria-role check port (untranslated)
danielweck Mar 10, 2021
45529c1
epub-type-has-matching-role pagebreak-label ported from Ace (translat…
danielweck Mar 10, 2021
5e5e6a7
working XHTML unit tests for EPUB in Axe! (port from Ace)
danielweck Mar 11, 2021
e460f1d
page-break label test (check)
danielweck Mar 11, 2021
da8e26c
Merge branch 'v4.1.3_DAISY' into v4.1.4_DAISY
danielweck Apr 6, 2021
908db3d
fixed semantic versioning handling (major.minor.patch-prerelease.buil…
danielweck Apr 6, 2021
9d64963
fixed dd, dt, dl, dfn lookup table
danielweck Apr 6, 2021
2565b38
re-instated DAISY mods
danielweck Apr 6, 2021
d61e3dd
DAISY landmark-one-main rule really is "has a unique main landmark ..…
danielweck Apr 6, 2021
e8e5645
get role type is super class role now (DAISY patch)
danielweck Apr 6, 2021
20748a7
super class role checks
danielweck Apr 6, 2021
3ce8040
owned roles fix for biblioentry and doc-endnote
danielweck Apr 6, 2021
4140347
DPUB ARIA 1.1 align https://w3c.github.io/dpub-aria/#changelog
danielweck Apr 7, 2021
05d0726
DPUB ARIA 1.1. deprecate doc-biblioentry and doc-endnote
danielweck Apr 7, 2021
c5005ba
further relaxation of doc-endnote and doc-biblioentry (deprecated in …
danielweck Apr 7, 2021
7673aaa
version bump and URL update
danielweck Apr 7, 2021
1a8dd7a
fixes landmark-unique (DPUB roles) https://github.com/daisy/ace/issue…
danielweck Apr 7, 2021
d159e51
version bump
danielweck Apr 7, 2021
09b6abe
Axe landmark unique fixes (weird DOM parser bug ignores some element …
danielweck Apr 7, 2021
a8d882a
added unit test for landmark unique (broken DOM parser it seems)
danielweck Apr 7, 2021
491abc8
final round of fixes for landmark unique (rule filter takes precedenc…
danielweck Apr 7, 2021
21375e0
version bump
danielweck Apr 7, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DPUB ARIA 1.1. deprecate doc-biblioentry and doc-endnote
danielweck committed Apr 7, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 05d072659ad60486f82035f3d20202339e09dafa
12 changes: 6 additions & 6 deletions lib/commons/aria/lookup-table.js
Original file line number Diff line number Diff line change
@@ -611,9 +611,9 @@ lookupTable.role = {
attributes: {
allowed: ['aria-expanded', 'aria-errormessage']
},
owned: {
one: ['doc-biblioentry']
},
// owned: {
// one: ['doc-biblioentry']
// },
nameFrom: ['author'],
context: null,
unsupported: false,
@@ -735,9 +735,9 @@ lookupTable.role = {
attributes: {
allowed: ['aria-expanded', 'aria-errormessage']
},
owned: {
one: ['doc-endnote']
},
// owned: {
// one: ['doc-endnote']
// },
namefrom: ['author'],
context: null,
unsupported: false,
4 changes: 2 additions & 2 deletions lib/standards/dpub-roles.js
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ const dpubRoles = {
},
'doc-bibliography': {
type: 'landmark',
requiredOwned: ['doc-biblioentry'],
// requiredOwned: ['doc-biblioentry'],
allowedAttrs: ['aria-expanded'],
superclassRole: ['landmark']
},
@@ -97,7 +97,7 @@ const dpubRoles = {
},
'doc-endnotes': {
type: 'landmark',
requiredOwned: ['doc-endnote'],
// requiredOwned: ['doc-endnote'],
allowedAttrs: ['aria-expanded'],
superclassRole: ['landmark']
},
Original file line number Diff line number Diff line change
@@ -35,6 +35,16 @@
<li role="doc-endnote"></li>
</ul>
</div>
<div role="doc-bibliography" id="pass19">
<ul>
<li><p role="doc-biblioentry"></p></li>
</ul>
</div>
<div role="doc-endnotes" id="pass20">
<ul>
<li><p role="doc-endnote"></p></li>
</ul>
</div>
<div role="listbox" id="incomplete11">
<div></div>
</div>
Original file line number Diff line number Diff line change
@@ -28,7 +28,9 @@
["#pass15"],
["#pass16"],
["#pass17"],
["#pass18"]
["#pass18"],
["#pass19"],
["#pass20"]
],
"incomplete": [
["#incomplete1"],
@@ -39,8 +41,6 @@
["#incomplete6"],
["#incomplete7"],
["#incomplete8"],
["#incomplete9"],
["#incomplete10"],
["#incomplete11"]
]
}