Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type is AverageValue #354

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix: type is AverageValue #354

merged 1 commit into from
Jun 26, 2024

Conversation

omBratteng
Copy link
Member

api-bg hasn't auto scaled in ages, and looking at hpa in k8s

metric with type External specifies targetType Value but doesn't specify Value

So I think type should be AverageValue

@omBratteng omBratteng merged commit b8f5a44 into main Jun 26, 2024
2 checks passed
@omBratteng omBratteng deleted the fix-hpa-type branch June 26, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idoshamun idoshamun idoshamun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omBratteng @idoshamun