Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 BUG: text overflow issue on the post side widget #1496

Closed
1 task done
sshanzel opened this issue Oct 13, 2024 · 8 comments
Closed
1 task done

🐛 BUG: text overflow issue on the post side widget #1496

sshanzel opened this issue Oct 13, 2024 · 8 comments

Comments

@sshanzel
Copy link
Member

sshanzel commented Oct 13, 2024

What went wrong? 🤔

When a link is part of the Squad's description, it overflows like below.

Quick link: https://dly.to/Z36wbkFJyc8

image

Expected Behavior

It should just wrap the text to the next line.

Steps to Reproduce Issue

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See the error

Solution Proposed

No response

Screenshots

![DESCRIPTION](LINK.png)

Environment

No response

Browsers

No response

OS

No response

Version of daily.dev

No response

Additional Context

No response

Code of Conduct

  • I follow the conditions of this project.
@Abhi-Bohora
Copy link

Hello @sshanzel can you please assign this to me

@sshanzel
Copy link
Member Author

@Abhi-Bohora why not. Feel free to take a peek 🚀

@Abhi-Bohora
Copy link

Hello @sshanzel I can see this in production but in development, I cannot figure out how to reproduce this as per my understanding it needs two accounts one to create a squad and write some overflowing URL in the squad description or some squad with a link in the description. is there a way to create two accounts in development or some ways to reproduce this so i can fix this ? also if I create squad or click on Public squad in gitpod development environment it redirects me to localhost http://localhost:5002/squads/testsquad from gitpod environment and gives me This site can’t be reached in page

@sshanzel
Copy link
Member Author

sshanzel commented Oct 13, 2024

Hello @sshanzel I can see this in production but in development, I cannot figure out how to reproduce this as per my understanding it needs two accounts one to create a squad and write some overflowing URL in the squad description or some squad with a link in the description. is there a way to create two accounts in development or some ways to reproduce this so i can fix this ? also if I create squad or click on Public squad in gitpod development environment it redirects me to localhost http://localhost:5002/squads/testsquad from gitpod environment and gives me This site can’t be reached in page

Creating the Squad went through, the issue is with the URL from the sidebar as it is an absolute path. With GitPod it should actually be different. To get past this, once you have created the Squad, manually type in the URL bar the hostname of the gitpod env + /squads/testsquad.

For example, my env is hosted under https://5002-dailydotdev-apps-n7f8m4tjy4j.ws-us116.gitpod.io - append the squads link like: https://5002-dailydotdev-apps-n7f8m4tjy4j.ws-us116.gitpod.io/squads/testsquad.

@Abhi-Bohora
Copy link

@sshanzel I tried this but got this error please see the screenshot. my gitpod is running in https://5002-dailydotdev-apps-vwf4wjsihxt.ws-us116.gitpod.io/ and I have just created the testsquad and when I enter https://5002-dailydotdev-apps-vwf4wjsihxt.ws-us116.gitpod.io/squads/testsquad in URL I get the error shown in the screenshot.
1
Error
2

@satvik2131
Copy link

Yes , I am facing the same issue while using gitpod and created a separate issue for that
#1502

omBratteng added a commit to dailydotdev/apps that referenced this issue Oct 18, 2024
@omBratteng
Copy link
Member

Leaving this here if anyone wants a quick fix, just change this line from

https://github.com/dailydotdev/apps/blob/5508daae5031637a6f779c6f6b22ca3fb5982bf9/packages/shared/src/components/post/SquadPostWidgets.tsx#L48

<p className="mt-1 text-text-tertiary typo-callout">

to

<p className="mt-1 overflow-hidden text-ellipsis text-text-tertiary typo-callout">

@rebelchris
Copy link
Contributor

Closing this!

Thanks for the fix @Abhi-Bohora 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants