feat: cache cors requests #2048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In production, |
|
Same goes for |
|
That being said, it should be possible to add a global CORS rule to our api ingress. |
Yes, thats my TODO for tomorrow. |
capJavert
commented
Jul 10, 2024
| @@ -85,8 +85,9 @@ export default async function app( | |||
|
|
|||
| app.register(helmet); | |||
| app.register(cors, { | |||
| origin: isProd ? /daily\.dev$/ : true, | |||
| origin: isProd ? /^(?:https:\/\/)?(?:[\w-]+\.)*daily\.dev$/ : true, | |||
There was a problem hiding this comment.
before it would allow adaily.dev
There was a problem hiding this comment.
Good catch, otherwise we'd have to buy *daily.dev domains there are 💸
capJavert
requested review from
rebelchris,
omBratteng,
ilasw,
sshanzel and
nensidosari
rebelchris
approved these changes
Jul 11, 2024
omBratteng
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
front will again ping
api.and so introducing caching for cors requests dailydotdev/apps#3332/v1/adoes not supportOPTIONSmethod so CORS fails/ealready supports CORS/scrapedoes not supportOPTIONSmethod so CORS fails