fix: Use refs to select video tag to fix Safari bug #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update to vite, use latest vue tools Remove comment Update babel and package-lock Fix lint issues Fix lint issues Fix prettier Add github action Test before building * Lint ts files too * Add tsconfig Lint ts files too Add tsconfig Add tsconfig Use vanilla js in Vue does not work Still not working Add console log for vue mounted Gate off and blocked instead of playable THIS WORKS. Move div back into Vue. THIS WORKS Fix spacing Fix tsconfig remove edge cases Remove comments Remove video tile
✅ Deploy Preview for vue-call-object ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jamsea
force-pushed
the
hush/vue-refs
branch
from
519f227 to
c14e9e7
Compare
jayne-mast
approved these changes
Nov 11, 2022
Co-authored-by: Jayne Mast <[email protected]>
Co-authored-by: Jayne Mast <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saving the video track to Vue’s data() causes it to get wrapped up in Vue’s reactivity system causing issues in desktop and mobile Safari. The way around it was to handle video tracks with normal JavaScript, and replace the media stream using Daily's events.