Skip to content

Commit

Permalink
Update deprecation messages to not encourage testCallQuality()
Browse files Browse the repository at this point in the history
  • Loading branch information
mattieruth committed Jan 25, 2024
1 parent 0e46701 commit 60240de
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2051,15 +2051,15 @@ export interface DailyCall {
stopTestPeerToPeerCallQuality(): void;
/**
* @deprecated This function will be removed. Use the method
* testCallQuality()(recommended) or testPeerToPeerCallQuality() instead.
* testPeerToPeerCallQuality() instead.
*/
testConnectionQuality(options: {
videoTrack: MediaStreamTrack;
duration?: number;
}): Promise<DailyConnectionQualityTestStats>;
/**
* @deprecated This function will be removed. Use the method
* stopTestCallQuality() or stopTestPeerToPeerCallQuality() instead.
* stopTestPeerToPeerCallQuality() instead.
*/
stopTestConnectionQuality(): void;
updateSendSettings(settings: DailySendSettings): Promise<DailySendSettings>;
Expand Down
4 changes: 2 additions & 2 deletions src/module.js
Original file line number Diff line number Diff line change
Expand Up @@ -3383,7 +3383,7 @@ export default class DailyIframe extends EventEmitter {

async testConnectionQuality(args) {
console.warn(`testConnectionQuality() is deprecated: use \
testCallQuality()(recommended) or testPeerToPeerCallQuality() instead`);
testPeerToPeerCallQuality() instead`);
const stats = await this.testPeerToPeerCallQuality(args);
// return backwards compatible type
let bcStats = {
Expand Down Expand Up @@ -3440,7 +3440,7 @@ testCallQuality()(recommended) or testPeerToPeerCallQuality() instead`);

stopTestConnectionQuality() {
console.warn(`stopTestConnectionQuality() is deprecated: use \
stopTestCallQuality() or stopTestPeerToPeerCallQuality() instead`);
stopTestPeerToPeerCallQuality() instead`);
this.stopTestPeerToPeerCallQuality();
}

Expand Down

0 comments on commit 60240de

Please sign in to comment.