fix: issues with cli reading from package.json #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
tylersayshi
force-pushed
the
fix/create-waku
branch
from
8cac1bc to
64e5f37
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
reviewed
Oct 21, 2024
packages/create-waku/src/index.ts
Outdated
| @@ -161,7 +160,9 @@ Options: | |||
| } | |||
|
|
|||
| async function notifyUpdate() { | |||
| const packageJson = JSON.parse(readFileSync('../package.json', 'utf8')); | |||
| const packageJson = JSON.parse( | |||
| readFileSync(path.resolve(import.meta.dirname, '../package.json'), 'utf8'), | |||
There was a problem hiding this comment.
import.meta.dirname isn't available in Node 18.
https://nodejs.org/docs/latest-v18.x/api/esm.html#importmetaurl
Can you try this?
import { readFileSync } from 'node:fs';
const buffer = readFileSync(new URL('./data.proto', import.meta.url));There was a problem hiding this comment.
yep, that works, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #978 (comment)
Also fixed an issue where the default folder name was not showing on conflict