Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Adding a guide for cloudflare #889

Merged
merged 5 commits into from
Sep 19, 2024
Merged

feat(docs): Adding a guide for cloudflare #889

merged 5 commits into from
Sep 19, 2024

Conversation

rmarscher
Copy link
Contributor

Here is a guide with my current understanding of how to run develop and deploy Waku for Cloudflare Pages in the next release that includes the unstable API to access the Hono context.

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
waku ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 1:17pm

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Sep 17, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@rmarscher rmarscher force-pushed the feat/docs/cloudflare-guide branch 8 times, most recently from c6f2525 to 9c3cf8a Compare September 17, 2024 21:52
dai-shi
dai-shi reviewed Sep 17, 2024
View reviewed changes
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing the guide!

docs/guides/cloudflare.mdx Outdated Show resolved Hide resolved
dai-shi
dai-shi reviewed Sep 18, 2024
View reviewed changes
docs/guides/cloudflare.mdx Outdated Show resolved Hide resolved
@rmarscher rmarscher marked this pull request as draft September 18, 2024 13:59
@rmarscher rmarscher marked this pull request as ready for review September 19, 2024 02:23
@dai-shi
Copy link
Owner

dai-shi commented Sep 19, 2024

can you run prettier?

@rmarscher
Copy link
Contributor Author

can you run prettier?

I think I fixed it. Sorry, I have been using biome for other projects and it keeps getting in the way. Should I move this from docs/guides to docs/builder?

@dai-shi
Copy link
Owner

dai-shi commented Sep 19, 2024

Still failing?

I think guides is fine, as it's not only about "builder" or "deploy". Maybe we should mv builder/* -> guides/* ?

@rmarscher
Copy link
Contributor Author

🙄 I missed a line in the other code block. I was trying to copy the code block out, format it and copy it back in because vscode wasn't formatting it within the markdown... turns out I think it's because I installed an MDX extension.

Anyway... pnpx prettier -c --write docs/guides/cloudflare.mdx is way easier. Hopefully this is all set now.

@dai-shi dai-shi merged commit 58d957c into dai-shi:main Sep 19, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-shi dai-shi dai-shi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmarscher @dai-shi