Remove all delete statement related code and docs

Signed-off-by: Chen Dai <[email protected]>

DEVELOPER_GUIDE.rst

@@ -294,7 +294,6 @@ For test cases, you can use the cases in the following checklist in case you mis
 
 - *Other Statements*
 
-  - DELETE
   - SHOW
   - DESCRIBE
 

common/src/main/java/org/opensearch/sql/common/setting/Settings.java

@@ -7,11 +7,12 @@
 
 import com.google.common.base.Strings;
 import com.google.common.collect.ImmutableMap;
+import lombok.Getter;
+import lombok.RequiredArgsConstructor;
+
 import java.util.List;
 import java.util.Map;
 import java.util.Optional;
-import lombok.Getter;
-import lombok.RequiredArgsConstructor;
 
 /** Setting. */
 public abstract class Settings {
@@ -22,7 +23,6 @@ public enum Key {
     SQL_ENABLED("plugins.sql.enabled"),
     SQL_SLOWLOG("plugins.sql.slowlog"),
     SQL_CURSOR_KEEP_ALIVE("plugins.sql.cursor.keep_alive"),
-    SQL_DELETE_ENABLED("plugins.sql.delete.enabled"),
     SQL_PAGINATION_API_SEARCH_AFTER("plugins.sql.pagination.api"),
 
     /** PPL Settings. */

docs/user/index.rst

@@ -43,10 +43,6 @@ OpenSearch SQL enables you to extract insights out of OpenSearch using the famil
 
   - `Window Functions <dql/window.rst>`_
 
-* **Data Manipulation Language**
-
-  - `DELETE Statement <dml/delete.rst>`_
-
 * **Beyond SQL**
 
   - `PartiQL (JSON) Support <beyond/partiql.rst>`_

integ-test/src/test/java/org/opensearch/sql/legacy/ExplainIT.java

@@ -5,25 +5,21 @@
 
 package org.opensearch.sql.legacy;
 
-import static org.hamcrest.Matchers.containsString;
-import static org.hamcrest.Matchers.equalTo;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_ACCOUNT;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_DOG;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_LOCATION;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_NESTED_TYPE;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_PEOPLE;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_PHRASE;
-
 import com.google.common.io.Files;
-import java.io.File;
-import java.io.IOException;
-import java.nio.charset.StandardCharsets;
 import org.junit.Assert;
 import org.junit.Ignore;
 import org.junit.Test;
 import org.opensearch.client.Request;
 import org.opensearch.client.Response;
 
+import java.io.File;
+import java.io.IOException;
+import java.nio.charset.StandardCharsets;
+
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.equalTo;
+import static org.opensearch.sql.legacy.TestsConstants.*;
+
 public class ExplainIT extends SQLIntegTestCase {
 
   @Override
@@ -135,24 +131,6 @@ public void searchSanityFilter() throws IOException {
         result.replaceAll("\\s+", ""), equalTo(expectedOutput.replaceAll("\\s+", "")));
   }
 
-  @Test
-  public void deleteSanity() throws IOException {
-
-    String expectedOutputFilePath =
-        TestUtils.getResourceFilePath("src/test/resources/expectedOutput/delete_explain.json");
-    String expectedOutput =
-        Files.toString(new File(expectedOutputFilePath), StandardCharsets.UTF_8)
-            .replaceAll("\r", "");
-    ;
-
-    String result =
-        explainQuery(
-            String.format(
-                "DELETE FROM %s WHERE firstname LIKE 'A%%' AND age > 20", TEST_INDEX_ACCOUNT));
-    Assert.assertThat(
-        result.replaceAll("\\s+", ""), equalTo(expectedOutput.replaceAll("\\s+", "")));
-  }
-
   @Test
   public void spatialFilterExplainTest() throws IOException {
 

integ-test/src/test/java/org/opensearch/sql/legacy/PluginIT.java

@@ -5,22 +5,21 @@
 
 package org.opensearch.sql.legacy;
 
-import static org.hamcrest.Matchers.equalTo;
-import static org.opensearch.sql.legacy.TestUtils.getResponseBody;
-import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_ACCOUNT;
-
-import java.io.IOException;
-import java.util.Locale;
 import org.json.JSONObject;
 import org.junit.Test;
 import org.opensearch.client.Request;
 import org.opensearch.client.RequestOptions;
 import org.opensearch.client.Response;
 import org.opensearch.client.ResponseException;
-import org.opensearch.sql.common.setting.Settings;
-import org.opensearch.sql.legacy.utils.StringUtils;
 import org.opensearch.sql.plugin.rest.RestQuerySettingsAction;
 
+import java.io.IOException;
+import java.util.Locale;
+
+import static org.hamcrest.Matchers.equalTo;
+import static org.opensearch.sql.legacy.TestUtils.getResponseBody;
+import static org.opensearch.sql.legacy.TestsConstants.TEST_INDEX_ACCOUNT;
+
 public class PluginIT extends SQLIntegTestCase {
 
   @Override
@@ -59,31 +58,6 @@ public void sqlEnableSettingsTest() throws IOException {
     wipeAllClusterSettings();
   }
 
-  @Test
-  public void sqlDeleteSettingsTest() throws IOException {
-    updateClusterSettings(
-        new ClusterSetting(PERSISTENT, Settings.Key.SQL_DELETE_ENABLED.getKeyValue(), "false"));
-
-    String deleteQuery = StringUtils.format("DELETE FROM %s", TestsConstants.TEST_INDEX_ACCOUNT);
-    final ResponseException exception =
-        expectThrows(ResponseException.class, () -> executeQuery(deleteQuery));
-    JSONObject actual = new JSONObject(TestUtils.getResponseBody(exception.getResponse()));
-    JSONObject expected =
-        new JSONObject(
-            "{\n"
-                + "  \"error\": {\n"
-                + "    \"reason\": \"Invalid SQL query\",\n"
-                + "    \"details\": \"DELETE clause is disabled by default and will be deprecated."
-                + " Using the plugins.sql.delete.enabled setting to enable it\",\n"
-                + "    \"type\": \"SQLFeatureDisabledException\"\n"
-                + "  },\n"
-                + "  \"status\": 400\n"
-                + "}");
-    assertTrue(actual.toString(), actual.similar(expected));
-
-    wipeAllClusterSettings();
-  }
-
   @Test
   public void sqlTransientOnlySettingTest() throws IOException {
     // (1) compact form

legacy/src/main/antlr/OpenSearchLegacySqlLexer.g4

@@ -57,7 +57,6 @@ CASE:                               'CASE';
 CAST:                               'CAST';
 CROSS:                              'CROSS';
 DATETIME:                           'DATETIME';
-DELETE:                             'DELETE';
 DESC:                               'DESC';
 DESCRIBE:                           'DESCRIBE';
 DISTINCT:                           'DISTINCT';