Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #79 - add Remove-MergedGitBranch command #663

Merged
merged 16 commits into from
Feb 24, 2019

Conversation

rkeithhill
Copy link
Collaborator

@rkeithhill rkeithhill commented Feb 19, 2019

Not sure if this command should require confirmation by default.

Perhaps we also need a Remove-GitBranch command which would need
confirmation.

Fix #79

@rkeithhill rkeithhill requested a review from dahlbyk February 19, 2019 06:54
@rkeithhill
Copy link
Collaborator Author

Also, if using --merged I don't think you'd ever need to use -D (force delete), would you?

Not sure if this command should require confirmation by default.

Perhaps we also need a Remove-GitBranch command which would need
confirmation.
@rkeithhill rkeithhill force-pushed the rkeithhill/impl-remove-mergedbranch branch from b605a57 to 2af13ed Compare February 20, 2019 00:55
@rkeithhill
Copy link
Collaborator Author

Also, wondering if this should be just Remove-GitBranch and then add a -Merged switch to change its behavior to remove only merged branches. Or we could default to only deleting merged and add a -All switch to delete all branches except the default exclude pattern (excludes the current branch as well as master and develop).

@rkeithhill rkeithhill merged commit c962003 into master Feb 24, 2019
@rkeithhill rkeithhill deleted the rkeithhill/impl-remove-mergedbranch branch February 24, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant