Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG for 1.0.0-beta1 release #521

Merged
merged 9 commits into from
Jan 12, 2018
Merged

Update CHANGELOG for 1.0.0-beta1 release #521

merged 9 commits into from
Jan 12, 2018

Conversation

rkeithhill
Copy link
Collaborator

I'm presuming beta1 but I think that is the appropriate moniker. I think we're further along than an alpha.

I guess the README.md update will come later. Question is, should I update the master readme since that is the default readme folks will see? Or should we rely on folks to switch to the develop branch. For sure, the README on develop should be updated.

@mikesigs @dahlbyk
Specify CommandType as Application
a91bfd7 
Related #478. This is a better fix. By specifying the CommandType as Application we can continue looking for `git` (exe or cmd) but avoiding any potential aliases the user may have created for "git".
@rkeithhill rkeithhill requested a review from dahlbyk January 10, 2018 05:41
@dahlbyk
Copy link
Owner

dahlbyk commented Jan 10, 2018

FYI, I'm going to pull the 0.7.2 bits out of these changes into a CHANGELOG update in master, then merge that up into develop onto which I'll rebase this update.

I'm presuming beta1 but I think that is the appropriate moniker. I think we're further along than an alpha.

beta1 is fine.

I guess the README.md update will come later. Question is, should I update the master readme since that is the default readme folks will see? Or should we rely on folks to switch to the develop branch. For sure, the README on develop should be updated.

Target develop for all things 1.0. Once 1.0 is released I plan to push master to maint-v0 or something, develop to master, and update both branch's READMEs accordingly.

@rkeithhill
Copy link
Collaborator Author

I'll work on the README tomorrow. Pretty much cooked for tonight.

rkeithhill and others added 4 commits January 10, 2018 00:12
@rkeithhill @dahlbyk
Export $GitPromptScriptBlock variable
72c8747 
Allow advanced users to invoke the $scriptblock from their own prompt functions.
@bergmeister @dahlbyk
autofix PSSA warnings whilst preserving the encoding
e356d3b
@dahlbyk
Add DefaultPromptPath setting
74ec4d2 
And export Get-PromptPath to expose our default path logic
@dahlbyk
Update changelog for 0.7.2
6b0de00
@dahlbyk dahlbyk mentioned this pull request Jan 10, 2018
Merged
@dahlbyk dahlbyk force-pushed the rkeithhill/upd-changelog2 branch from e636fb6 to 21fb58a Compare January 10, 2018 09:09
@dahlbyk
Copy link
Owner

dahlbyk commented Jan 10, 2018

https://www.powershellgallery.com/packages/posh-git/1.0.0-beta1 is now available.

@dahlbyk dahlbyk mentioned this pull request Jan 10, 2018
Open
13 tasks
@rkeithhill
Copy link
Collaborator Author

Don't we need to merge this in at some point?

@dahlbyk
Copy link
Owner

dahlbyk commented Jan 12, 2018

Will merge after CI passes. I've reset the links to develop and bumped version to beta1x until it's time for beta2.

@dahlbyk dahlbyk merged commit a434d5c into develop Jan 12, 2018
@dahlbyk dahlbyk deleted the rkeithhill/upd-changelog2 branch January 12, 2018 21:31
rkeithhill
rkeithhill commented Jan 12, 2018
View reviewed changes
src/posh-git.psd1 Outdated

# OVERRIDE THIS FIELD FOR PUBLISHED RELEASES - LEAVE AT 'alpha' FOR CLONED/LOCAL REPO USAGE
Prerelease = 'beta1'
Prerelease = 'beta1x'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for folks who have git cloned and then import right? I assume this will cause repo bits to have precedence over the installed beta1. Is that the idea with beta1x?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. beta1 < beta1x < beta2

@rkeithhill
Copy link
Collaborator Author

BTW, I'm still working on the README update. Hopefully I can get a PR created for that by late Saturday. FWIW once I mananged to get PSReadLine 2.0.0-beta1 installed on my Ubuntu VM and WSL/Ubuntu, posh-git 1.0.0-beta1 has been working great!

@dahlbyk
Copy link
Owner

dahlbyk commented Jan 13, 2018

FYI, I am working on reformatting the top of the master/v0.x readme to clarify the versions available. O figure we can iterate on that, and then merge those changes into develop to go along with v1-specific updates. Reasonable?

Should we add a warning if we detect an incompatible version of PSReadLine on load?

@rkeithhill
Copy link
Collaborator Author

rkeithhill commented Jan 13, 2018 •
edited
Loading

Sounds good. Yeah, we could add a warning for beta2. This only seems to impact Linux/macOS users. Supposedly PSRL 2 will ship with PS Core 6.1 when that ships - probably in ~6 months.

@dahlbyk dahlbyk added this to the v1.0 milestone Apr 17, 2018
@dahlbyk dahlbyk mentioned this pull request May 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlbyk dahlbyk dahlbyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rkeithhill @dahlbyk @mikesigs @bergmeister