Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'push' to the list of commands to handle tab tag completion #286

Merged
merged 1 commit into from
May 25, 2016

Conversation

joshgo
Copy link

@joshgo joshgo commented May 25, 2016

Hi Keith, First time using posh-git. I'm not a powershell guy, but I was able to follow the code and make the minor modification. Hopefully, that's all that is needed. I added this because tab completion for tags exist in Git Bash when using "git push".

@dahlbyk
Copy link
Owner

dahlbyk commented May 25, 2016

We handle push a little differently because ` is required before the branch/tag. Try here instead?

@joshgo
Copy link
Author

joshgo commented May 25, 2016

` is required before the branch/tag
Single quote/accent ? Apologies, I'm not sure what you are saying.

I looked at line 233-235 as per your suggestion, that doesn't get invoked when I type:

git push origin {tab-key}

Line 239-241 is what gets invoked.

If I add a call to gitTags, it works. Without changing the regex variable name, the call would be: gitTags matches['branch']. I don't like that it says 'branch', it's a little misleading...but works.

@dahlbyk
Copy link
Owner

dahlbyk commented May 25, 2016

Line 239-241 is what gets invoked.

Oh, right you are. 233-235 is specifically for git push foo bar:<tab>.

I don't like that it says 'branch', it's a little misleading...but works.

Agreed. Let's change that to ref.

@joshgo joshgo force-pushed the add-push-for-tag-completion branch from 9c14b44 to 4896346 Compare May 25, 2016 20:19
@joshgo
Copy link
Author

joshgo commented May 25, 2016

Changes are done. Thanks for feedback.

@dahlbyk dahlbyk merged commit 19f3f2e into dahlbyk:master May 25, 2016
@dahlbyk
Copy link
Owner

dahlbyk commented May 25, 2016

✨ 🙇

@joshgo joshgo deleted the add-push-for-tag-completion branch May 25, 2016 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants