Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BranchBehindAndAheadDisplay 'Minimal' Setting #670

Closed
rdnlsmith opened this issue Mar 26, 2019 · 2 comments
Closed

BranchBehindAndAheadDisplay 'Minimal' Setting #670

rdnlsmith opened this issue Mar 26, 2019 · 2 comments
Assignees
Milestone

Comments

@rdnlsmith
Copy link
Contributor

System Details

  • posh-git version/path: 1.0.0 beta2 ~/.local/share/powershell/Modules/posh-git/1.0.0
  • PowerShell version: 6.1.1
  • git version 2.19.1
  • OS: Unix 4.18.0.16

Issue Description

Apologies if this has already been answered elsewhere. I did my best to search for relevant information first, but I couldn't find what I was looking for.

When the BranchBehindAndAheadDisplay setting was first introduced in #256, Minimal would show ↑, ↓, or ↕ as appropriate with no counts. As of commit 4d8e08c, Minimal does not show any arrows, but the branch name is still colored red/green/yellow.

Was this a deliberate change? Obviously the color is sufficient to indicate its remote tracking status, but it seemed odd to me that the arrows would be removed given that it still displays the ≡ symbol when the branch is even with its remote. I couldn't find an issue where this might have been discussed, and it's not mentioned in the changelog for version 0.7.3, which was the next release after that commit.

I only noticed because I was working on an equivalent feature for lyze/posh-git-sh#37 and I wanted to ensure it behaved the same. I like Full myself 😃

Thanks for all your work! posh-git is fantastic.

@rkeithhill
Copy link
Collaborator

rkeithhill commented Mar 26, 2019

Good catch! Does this display look better?

image

@rdnlsmith
Copy link
Contributor Author

Looks great!

@rkeithhill rkeithhill added this to the v1.0 milestone Mar 28, 2019
rkeithhill added a commit that referenced this issue Mar 28, 2019
…h-ahead-behind-display

Fix #670 BranchBehindAndAheadDisplay minimal/compact bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants