Set HResult of exceptionForHR with message #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimalZed
commented
Aug 19, 2024
| exceptionForHR = constructor?.Invoke(new object[] { message! }) as Exception; | ||
| var constructor = exceptionForHR.GetType().GetConstructor(new Type[] { typeof(string) })!; | ||
| exceptionForHR = constructor.Invoke(new object[] { message! }) as Exception; | ||
| # if NETCOREAPP3_0_OR_GREATER |
There was a problem hiding this comment.
HResult property had protected set prior to .NET Core 3.0
PrimalZed
commented
Aug 19, 2024
| @@ -50,6 +50,10 @@ public void GetExceptionTest() | |||
| Assert.That(new HRESULT(HRESULT.CO_E_ATTEMPT_TO_CREATE_OUTSIDE_CLIENT_CONTEXT).GetException(), Is.TypeOf<COMException>()); | |||
| Assert.That(new HRESULT(HRESULT.E_INVALIDARG).GetException(), Is.TypeOf<ArgumentException>()); | |||
| Assert.That(new HRESULT(HRESULT.E_INVALIDARG).GetException("Bad"), Has.Message.EqualTo("Bad")); | |||
| #if NETCOREAPP3_0_OR_GREATER | |||
| var win32HResult = new Win32Error(Win32Error.ERROR_SHARING_VIOLATION).ToHRESULT(); | |||
There was a problem hiding this comment.
this is the particular hresult I found the issue with. It returns a FileLoadException which has default hresult COR_E_FILELOAD 0x80131621, which differs from this win32HResult value 0x80070020
There was a problem hiding this comment.
Both of these HResult values can be seen here: https://source.dot.net/#System.Threading/src/libraries/Common/src/System/HResults.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using
HRESULT.ThrowIfFailedwith a non-null message, the returned exception might not have the correct HResult value.Root Cause
When
HRESULT.GetExceptionis called with a non-null message, it creates a new exception with the same type as the exception fromMarshal.GetExceptionForHR, expecting a constructor that takes a string message.It does not set the HResult of this new exception.
Fix
Set
HResultof new exception