Supporting dask clusters #2498
Merged
Supporting dask clusters #2498
+99
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natekupp
reviewed
May 22, 2020
base on discussion in PR
edit docstring.
|
Great—I kicked off a Buildkite build here: https://buildkite.com/dagster/dagster/builds/12891 A few follow-ups from that:
|
alangenfeld
added a commit
that referenced
this pull request
Oct 28, 2020
Summary: This is a capability we advertise in the docs that was removed in #2498, I think on accident. The top level `Client` object in dask takes either a `Cluster` object - which all the existing config schema is used to control, or just a string indicating the address of a running scheduler https://distributed.dask.org/en/latest/client.html I also cleaned up false advertising about python 2 support since dask does not run on py2 Test Plan: new test Reviewers: nate, max, sandyryza Reviewed By: nate Differential Revision: https://dagster.phacility.com/D4925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support executing on more dask-clusters (e.g.
yarn).Solving this issue.