fix tests

dagster-io · Jul 30, 2020 · 0df6894 · 0df6894
1 parent 0e977ab
commit 0df6894
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/python_modules/libraries/dagster-dask/dev-requirements.txt b/python_modules/libraries/dagster-dask/dev-requirements.txt
@@ -0,0 +1,2 @@
+# we need `pyarrow` for testing read/write parquet files.
+pyarrow
diff --git a/python_modules/libraries/dagster-dask/setup.py b/python_modules/libraries/dagster-dask/setup.py
@@ -30,7 +30,7 @@ def get_version():
             'bokeh',
             'dagster',
             'dagster_graphql',
-            'dask>=1.2.2',
+            'dask[dataframe]>=1.2.2',
             'distributed>=1.28.1',
         ],
         extras_require={

diff --git a/python_modules/libraries/dagster-dask/tox.ini b/python_modules/libraries/dagster-dask/tox.ini
@@ -10,6 +10,7 @@ deps =
   -e ../dagster-aws
   -e ../dagster-pandas
   -e .
+  -r dev-requirements.txt
 extras = yarn,pbs,kube
 usedevelop = true
 whitelist_externals =
@@ -19,8 +20,6 @@ commands =
   !windows: /bin/bash -c '! pip list --exclude-editable | grep -e dagster -e dagit'
   coverage erase
   echo -e "--- \033[0;32m:pytest: Running tox tests\033[0m"
-  python -m pip install "dask[dataframe]" --upgrade
-  pip install pyarrow  
   pytest -vv --junitxml=test_results.xml --cov=dagster_dask --cov-append --cov-report=
   coverage report --omit='.tox/*,**/test_*.py' --skip-covered
   coverage html --omit='.tox/*,**/test_*.py'
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		# we need `pyarrow` for testing read/write parquet files.
		pyarrow