feat: support passing core type arrays to dagger call (#6030)

* fix: always propagate error from marshalling Failing to marshal an argument should be preserved - if the caller discards the error, expecting it to fail later, the behaviour is very strange, and we get an empty string. Signed-off-by: Justin Chadwell <[email protected]> * fix: marshal interface types as their element Signed-off-by: Justin Chadwell <[email protected]> * feat: support passing core type arrays to dagger call Signed-off-by: Justin Chadwell <[email protected]> --------- Signed-off-by: Justin Chadwell <[email protected]>
dagger · Oct 31, 2023 · dbf26a1 · dbf26a1
1 parent 351d54f
commit dbf26a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/querybuilder/marshal.go b/querybuilder/marshal.go
@@ -66,7 +66,7 @@ func marshalValue(ctx context.Context, v reflect.Value) (string, error) {
 		var buf bytes.Buffer
 		gqlgen.MarshalString(v.String()).MarshalGQL(&buf)
 		return buf.String(), nil //nolint:gosimple,staticcheck
-	case reflect.Pointer:
+	case reflect.Pointer, reflect.Interface:
 		if v.IsNil() {
 			return "null", nil
 		}

diff --git a/querybuilder/querybuilder.go b/querybuilder/querybuilder.go
@@ -168,15 +168,16 @@ func (s *Selection) Execute(ctx context.Context, c graphql.Client) error {
 }
 
 type argument struct {
-	value      any
-	marshalled string
-	once       sync.Once
+	value any
+
+	marshalled    string
+	marshalledErr error
+	once          sync.Once
 }
 
 func (a *argument) marshal(ctx context.Context) error {
-	var err error
 	a.once.Do(func() {
-		a.marshalled, err = MarshalGQL(ctx, a.value)
+		a.marshalled, a.marshalledErr = MarshalGQL(ctx, a.value)
 	})
-	return err
+	return a.marshalledErr
 }