feat: add fmt capabilities

[b4nst]

An attempt at including formatting to the LSP. I'm quite new to LSP implementation, not sure if there's a standard for passing options to the formatter. I'll dig a bit in the doc later see if I find something useful.

Resolves #44

[b4nst]

Went a bit too fast on this one. I need to get the file from the workspace and not a dumb os.ReadFile, otherwise it doesn't take current changes into account 🤦 .

[TomChv]

Hey, thanks for your time and contribution 🚀

Went a bit too fast on this one. I need to get the file from the workspace and not a dumb os.ReadFile, otherwise it doesn't take current changes into account 🤦 .

Actually I think it's ok to keep the same logic as cue fmt and format the full file.
That's maybe a simpler implementation for now?

[b4nst]

I don't see any issue formatting the whole file. However when doing some tests, it seems the os.ReadFile is happening before the file is actually saved. I guess that's the normal flow of an on save hook: hit save => triggers hooks => actually save with the modified file.
Meaning I ended up overriding my changes with the last state saved in file. It's also maybe an issue with the lsp client (I'm using Helix editor embedded client) that should send the current buffer instead of the local path. Not sure of the right client implementation for this feature.

[grouville]

I've tested locally, and it seems that it overrides the local changes, prior saving. A solution would be to maybe move that function to the onsave handler, or find a way to update before that (doing a reload of the plan)

[grouville]

matting the whole file. However when doing some tests, it seems the os.ReadFile is happening before the file is actually saved. I guess that's the normal flow of an on save hook: hit save => triggers hooks => actually save with the modified file.
Meaning I ended up overriding my cha

I'll take some time to explore today 😇

[b4nst]

I wonder if we should start implementing documentDidChange and reload the plan with changes. And then use the plan itself to somehow get the file content, or the ast.Node to feed it to format.Source or format.Node.
I'm just a bit concerned by the performances of a plan reload with every changes.

[b4nst]

I ran some quick and dirty stuff here, using a simple sync.Map as a storage. And it does work.

So I guess updating the Plan and getting back the file directly from it should solve our issue. I'll explore a way to do so

[b4nst]

@grouville I updated my code to take the file directly from the plan and add an override system to the plan. It seems to work well but it feels kinda hacky tbh.
I'm wonderning if we wouldn't be better using the Overlay capabilities of load.Config

[TomChv]

I'll take some time today to check your solution too

[grouville]

@b4nst. I've been checking your solution, and it seems that it continues overwriting the user's input. It's more subtile, but it can still annoy the users:

Enregistrement.de.l.ecran.2022-08-08.a.14.44.31.mov

Do you have an idea on where this happens ?

[b4nst]

Huum, maybe because the file didn't build correctly it was not in the list of files of the main Plan. I honestly have to give a better try to this one. It requires more work than this sort of hack