-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IOrigin
to make the Dafny AST easier to work with
#5931
Open
keyboardDrummer
wants to merge
16
commits into
dafny-lang:master
Choose a base branch
from
keyboardDrummer:iOriginStart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
changed the title
Rename
Introduce Nov 26, 2024
IToken
to IOrigin
and reduce messiness around 'token wrapping'IOrigin
to reduce headache around tokens
keyboardDrummer
changed the title
Introduce
Introduce Nov 26, 2024
IOrigin
to reduce headache around tokensIOrigin
to make the Dafny AST easier to work with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IOrigin
, which always has aToken StartToken
,Token EndToken
andToken Center
Token
type, instead ofIToken
INode
had.Tok
and.RangeToken
properties. Now it has anIOrigin
that should replace both of those. Usages of.RangeToken
have already been replaced, but usages of.Tok
will be tackled in a follow-up PR.IToken
, is now done onIOrigin
.Dafny.IToken
no longer exists.Boogie.IToken
is still thereIToken
s, which could be wrapped, but only takes twoToken
instances.Future
Node.tok/Tok
withNode.Origin
RangeToken
toSourceOrigin
, and include a field for containing the "Center". RenameRangeNode
toOriginNode
TokenNode
withRangeNode
, after whichRangeNode
can be merged intoNode
IOrigin
, so users must always choose to use Start/End/Center.How has this been tested?
Pure refactoring, covered by existing tests
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.