Allow static reveal of instance function in new resolver #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test for this is in `git-issues/git-issue-4315.dfy`
RustanLeino
added a commit
to RustanLeino/dafny
that referenced
this pull request
Nov 1, 2023
…er does" This reverts commit 483af6c. This change has been moved to a separate PR: dafny-lang#4733
MikaelMayer
previously approved these changes
Nov 2, 2023
There was a problem hiding this comment.
It's unfortunate indeed, but it's the way the translator worked that made this change the most straightforward. The translator does not care about the "this" part, only the member and function, so "this.f" serves only as a pointer to the function. I'm not sure how we could store a pointer to a non-static function in a resolved expression otherwise.
Good job for making the new resolver up to date with that change.
If appropriate, can you please add an entry like doc/dev/4733.fix containing something like "The new type checker now also supports static reveals for instance functions" ?
MikaelMayer
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #4180 introduced the ability to
revealan instance function in a static context. In the recent PR #4498, this has been implemented to put the instance function itself, without a receiver argument, into an attribute. The recent PR then special-cases the resolution of that attribute. I would call that a hack.This PR mimics that hack for the new resolver. That makes
git-issue-4315.dfy(see Issue #4315) pass with both resolvers.The hack introduced in this PR and in #4498 is not a great idea, because a use of
thisis placed into the AST in a context where there is nothis. If (rather, when) this gets fixed, it should be fixed in both resolvers.How has this been tested?
Test
git-issues/git-issue-4315.dfyhas been converted to run with both the old and new resolver.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.