Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread leak #4570

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Fix thread leak #4570

merged 9 commits into from
Sep 25, 2023

Conversation

keyboardDrummer
Copy link
Member

@keyboardDrummer keyboardDrummer commented Sep 20, 2023 •
edited
Loading

Changes

  • Clean up event loop threads to prevent the IDE from using more and more threads
  • Some concurrency related hygiene improvements
  • Fix the test DoNotResendAfterNoopChange, that for a reason I couldn't discover was passing when it shouldn't have.

Testing

Added test that detects the issue

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) September 20, 2023 13:22
MikaelMayer
MikaelMayer previously approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job for finding a test!

MikaelMayer
MikaelMayer previously approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look like an experimentation to enhance thread stability, so if the tests pass I'm ok with them.

@keyboardDrummer keyboardDrummer merged commit 7aca3a6 into dafny-lang:master Sep 25, 2023
18 checks passed
@keyboardDrummer keyboardDrummer deleted the cleanupEventLoopThreads branch September 25, 2023 13:42
keyboardDrummer added a commit that referenced this pull request Sep 26, 2023
@keyboardDrummer
Fix thread leak (#4570)
6039f32 
### Changes

Clean up event loop threads to prevent the IDE from using more and more
threads

### Testing

Added test that detects the issue

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
@BrewTestBot BrewTestBot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelMayer MikaelMayer MikaelMayer approved these changes

@robin-aws robin-aws Awaiting requested review from robin-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keyboardDrummer @MikaelMayer @robin-aws