Report errors that occur in the project file, in the IDE as well #4539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
reviewed
Sep 12, 2023
Co-authored-by: Mikaël Mayer <[email protected]>
Co-authored-by: Mikaël Mayer <[email protected]>
…mmer/dafny into reportProjectFileErrorsInIde
MikaelMayer
previously approved these changes
Sep 13, 2023
| } | ||
| } | ||
|
|
||
| var verificationDocumentItem = CreateTestDocument("class X {does not parse", $"AssertNoDiagnosticsAreComing{fileIndex++}.dfy"); |
There was a problem hiding this comment.
I love this non-parsing file :-)
| }); | ||
| var hideReport = await diagnosticsReceiver.AwaitNextNotificationAsync(cancellationToken.Value); | ||
| AssertM.Equal(verificationDocumentItem.Uri, hideReport.Uri, | ||
| "2) Unexpected diagnostics were received whereas none were expected:\n" + |
There was a problem hiding this comment.
No idea. This line is copy+pasted.
That requires a change in the VSCode extension, because currently the extension only sends I plan to make that change but it is independent from this one. |
MikaelMayer
approved these changes
Sep 14, 2023
| @@ -78,7 +78,7 @@ ILogger<ITextDocumentLoader> logger | |||
| var projectDirectory = Path.GetDirectoryName(projectPath)!; | |||
| var filesMessage = string.Join("\n", compilation.RootUris.Select(uri => Path.GetRelativePath(projectDirectory, uri.LocalPath))); | |||
| if (filesMessage.Any()) { | |||
| program.Reporter.Info(MessageSource.Parser, compilation.Project.StartingToken, "Files referenced by project are:\n" + filesMessage); | |||
| program.Reporter.Info(MessageSource.Parser, compilation.Project.StartingToken, "Files referenced by project are:" + Environment.NewLine + filesMessage); | |||
There was a problem hiding this comment.
Oh yeah thanks for making sure Windows tests don't break!
TaBo2410
added a commit
that referenced
this pull request
Sep 20, 2023
…iment-trsplitexpr * commit '86840e6b14386c1e88480854dd8ce64ad17cb2ff': Map eq range (#4567) Fix: Declarations with {:only} ensure that other declarations aren't displayed as verified in the gutter icons (#4433) Fix caching of export declarations (#4556) Do not return exceptions when doing hover in a program with parse errors (#4557) Proof dependency warnings (#4542) [Test Generation] Reduce memory footprint by reusing the same Boogie program for multiple test generation queries (#4530) Fix a variety of bugs in Rust backend based on ESDK testing (#4538) Checker for .Values and .Items on maps (#4551) feat: Allow more assumptions in library backend (#4545) feat: Attributes on reads clauses (#4554) Fix gutter icons fields (#4549) Report errors that occur in the project file, in the IDE as well (#4539) Switch to ubuntu-20.04 for the refman build (#4555)
keyboardDrummer
added a commit
that referenced
this pull request
Sep 26, 2023
### Changes Report errors that occur in the project file, in the IDE as well ### Testing Added a unit test <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.