Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include both locations in duplicate module name error messages #4499

Merged

Conversation

keyboardDrummer
Copy link
Member

Fixes #4289

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@@ -221,7 +221,7 @@ public class ProjectManager : IDisposable {
return await CompilationManager.LastDocument;
}

public async Task<IdeState> GetSnapshotAfterParsingAsync() {
Copy link
Member Author

@keyboardDrummer keyboardDrummer Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are an unrelated tiny refactoring

Copy link
Collaborator

@stefan-aws stefan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is very helpful.

@stefan-aws stefan-aws linked an issue Sep 1, 2023 that may be closed by this pull request
@keyboardDrummer keyboardDrummer enabled auto-merge (squash) September 1, 2023 11:27
@keyboardDrummer keyboardDrummer merged commit 930de2b into dafny-lang:master Sep 5, 2023
18 checks passed
keyboardDrummer added a commit to keyboardDrummer/dafny that referenced this pull request Sep 15, 2023
…-lang#4499)

Fixes dafny-lang#4289

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer added a commit that referenced this pull request Sep 15, 2023
Fixes #4289

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer added a commit that referenced this pull request Sep 19, 2023
Fixes #4289

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
keyboardDrummer added a commit that referenced this pull request Sep 19, 2023
Fixes #4289

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants