Exposing --output and --spill-translation in dafny test, per Issue 3612 #3769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomb
requested changes
Mar 23, 2023
| var regex = program.Options.MethodsToTest; | ||
| if (regex != null) { | ||
| string name = method.FullDafnyName; | ||
| if (!Regex.Match(name, regex).Success) continue; |
There was a problem hiding this comment.
This should have braces, as the CI complains about.
| if (hasMain) { | ||
| Reporter.Error(MessageSource.Rewriter, mainMethod.tok, "Cannot use /runAllTests on a program with a main method"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
The code at the end of this file still calls hasMain and an assertion fails when running with /testContracts. I wonder whether the implementation of HasMain need to be updated to account for the possibility of the new synthetic name you're using?
There was a problem hiding this comment.
That was a satisfyingly simple fix. :)
…-3612-test-command
…afny into cok-3612-test-command
atomb
approved these changes
Mar 27, 2023
|
Hey, I feel like a bit of a broken record, but adding options to the CLI is a one-way door, so we should be careful about what we add. @davidcok did we consider alternatives to this option? How do you feel about the design sketched in #3612 (comment) ? |
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3612
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.