fix: Check extreme predicates and constants in all types, not just classes #2515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was latent in 923f812 (for datatypes), but the issue with
const
onlybecame exploitable in c5562f2 (previous to that Boogie's own cyclicity checks
replaced the missing ones in Dafny).
Source/Dafny/Resolver.cs
(ResolveTopLevelDecls_Core
):Run member checks on all declarations with members — not just on classes.
Closes #2506.
We were running none of the extreme lemma checks for datatypes, newtypes, and abstract type members. I added tests, but for casual readers, here are four examples: