refactor/optimize: remove dead code #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
该PR导致了一个额外的问题：无法解析任何域名 日志如下time="Jan 05 00:48:07" level=warning msg="handlePkt: listen udp 192.168.1.1:53: bind: address already in use"
time="Jan 05 00:48:08" level=warning msg="handlePkt: failed to write cached DNS resp: listen udp 192.168.1.1:53: bind: address already in use" |
|
@umlka 是不是你在dae运行的主机上同时还有一个进程绑定*:53 |
安装在openwrt上面，另一个绑定的进程是dnsmasq，0.5.0版本是正常的，我路由规则添加了 |
更改dnsmasq的监听端口为非53端口后可以正常使用了，但是这样会出现一些异常情况，比如路由器(通过PPPoE拨号上网, dae无法代理)本机上的DNS解析全部失效以及三星手机连不上路由器Wi-Fi(提示Wi-Fi无网络) |
3 tasks
|
@jschwinger233 Any updates on this one yet? |
With daeuniverse#383, dae no longer encap UDP, leaving this decap UDP logic obsolete. Removal of lan_egress also ends up with several helper functions unused, this commit deletes them as well. As for scenario of LAN==WAN, after this commit only wan_egress will be attached on LAN. Wan_egress therefore will pass all traffic sent from dae because pid_is_control_plane() gives true, so it looks like no concerns.
Also no longer necessary.
jschwinger233
force-pushed
the
gray/remove-udp-decap
branch
from
6b6a156 to
21bd374
Compare
|
@jschwinger233 @mzz2017 Shall we move on? |
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As #383 got merged, some logic seems obsolete and safe to remove.
This PR removes lan_egress bpf, followed by removal of lanWan flag at control plane.
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result