fix(bpf): sk_lookup_udp for listener only #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
force-pushed
the
gray/fix-udp-lookup
branch
from
2f738aa to
d13dff1
Compare
|
Great, it's so smooth now. |
|
Has this patch been fully tested yet? |
sumire88
changed the title
mzz2017
changed the title
Yes. Let's move on. |
![dae-prow[bot]](https://avatars.githubusercontent.com/in/345419?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Consider two consecutive
dig @1.1.1.1 one.one.one.one: dae will create a UDP socket binding1.1.1.1:53for the 1st DNS query, then by the time the 2nd one arrives at wan_egress@eth0, sk_lookup_udp will match that newly created UDP socket by mistake.As lookup for established UDP is not necessary at all, this PR skips that to avoid this tragedy bug.
Fixes: #383
Checklist
Full Changelogs
Issue Reference
Closes #[issue number]
Test Result