Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add more kernel tests #386

Merged
merged 3 commits into from
Jan 1, 2024
Merged

ci: Add more kernel tests #386

merged 3 commits into from
Jan 1, 2024

Conversation

jschwinger233
Copy link
Member

@jschwinger233 jschwinger233 commented Dec 29, 2023 •
edited
Loading

Covers IPv4 + IPv6 for TCP + UDP under WAN + LAN.

IPv6 UDP is buggy so I skipped that: #102 #387

@jschwinger233 jschwinger233 requested a review from a team as a code owner December 29, 2023 08:57
mzz2017
mzz2017 reviewed Dec 29, 2023
View reviewed changes
.github/workflows/kernel-test.yml
@@ -135,30 +157,111 @@ jobs:
}

routing {
dip(1.1.1.1) -> proxy
fallback: direct
pname(dae) -> direct
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#384

Pid matching doesnt work inside container

@jschwinger233 jschwinger233 force-pushed the gray/more-test branch 5 times, most recently from 2c3b7e9 to be7e024 Compare December 29, 2023 15:17
@jschwinger233 jschwinger233 marked this pull request as draft December 29, 2023 15:22
@jschwinger233 jschwinger233 force-pushed the gray/more-test branch 4 times, most recently from c74677f to 1b4a222 Compare December 29, 2023 16:03
@jschwinger233
Copy link
Member Author

jschwinger233 commented Dec 29, 2023 •
edited
Loading

IPv6 keeps failing, in my opinion this is because github action doesn't support IPv6 outbound to world: actions/runner-images#668.

I therefore plan to test IPv6 3-way handshake only, to make sure packets originated by a local process can finally arrive at dae process.

As for IPv6 UDP, it seems to be buggy on main. Will troubleshot that later.

@jschwinger233
Copy link
Member Author

好耶，IPv6 TCP for WAN / LAN 也测过了，ready for review.

@jschwinger233 jschwinger233 marked this pull request as ready for review December 30, 2023 05:16
@mzz2017
Copy link
Contributor

mzz2017 commented Dec 30, 2023

@jschwinger233 Exciting news. What about ipv6 udp?

@mzz2017
Copy link
Contributor

mzz2017 commented Dec 30, 2023

@jschwinger233 I think we should also test it whatever it has bug or not.

@jschwinger233 jschwinger233 force-pushed the gray/more-test branch 5 times, most recently from cdf938c to c541b22 Compare December 30, 2023 07:54
@jschwinger233
Copy link
Member Author

@mzz2017 IPv6 UDP testcase added.

@mzz2017
Copy link
Contributor

mzz2017 commented Dec 30, 2023 •
edited
Loading

Cool. Thanks for your brilliant work. I think it is ready to merge. @sumire88

mzz2017
mzz2017 previously approved these changes Dec 30, 2023
View reviewed changes
@jschwinger233 jschwinger233 marked this pull request as draft December 31, 2023 05:44
@jschwinger233 jschwinger233 marked this pull request as ready for review December 31, 2023 05:58
@jschwinger233 jschwinger233 mentioned this pull request Dec 31, 2023
Merged
@sumire88 sumire88 changed the title ci: Add more test ci: Add more kernel tests Jan 1, 2024
@sumire88
Copy link
Contributor

sumire88 commented Jan 1, 2024

Thanks for the hard work. @jschwinger233 @mzz2017 Happy New Year! Wish we would reach another milestone in 2024 🔥

@mzz2017 mzz2017 merged commit aedbd0a into daeuniverse:main Jan 1, 2024
5 checks passed
@dae-prow dae-prow bot mentioned this pull request Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumire88 sumire88 sumire88 approved these changes

@mzz2017 mzz2017 mzz2017 left review comments

Assignees

@jschwinger233 jschwinger233

Labels
ci not-yet-tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschwinger233 @mzz2017 @sumire88