Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/chore: remove the buildmode specified in CI #273

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

shenghuang147
Copy link
Contributor

@shenghuang147 shenghuang147 commented Aug 11, 2023

Background

This PR is because #272 has already selected whether to enable -buildmode=pie in Makefile according to GOARCH, so there is no need to specify -buildmode=pie in CI.

Checklist

Full Changelogs

  • [Implement ...]

Issue Reference

Closes #[issue number]

Test Result

@shenghuang147 shenghuang147 requested a review from a team as a code owner August 11, 2023 15:25
@dae-prow dae-prow bot added the chore label Aug 11, 2023
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piyoki piyoki added the tested label Aug 12, 2023
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki piyoki changed the title chore: remove the buildmode specified in CI ci/chore: remove the buildmode specified in CI Aug 12, 2023
@kunish kunish merged commit 4e71d68 into daeuniverse:main Aug 12, 2023
@piyoki piyoki mentioned this pull request Aug 14, 2023
3 tasks
@shenghuang147 shenghuang147 deleted the remove_ci_buildargs branch June 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants