Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: truncated dns resp #203

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: truncated dns resp #203

merged 1 commit into from
Jul 10, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jul 10, 2023 •
edited
Loading

Background

image

If a DNS response is too big (greater than 512 Bytes), it would be truncated. So the unpacking would fail.

This PR enlarges the buffer size to 2048. Hope it is not expensive.

Checklist

Full changelogs

  • Enlarge DNS response buffer to 2048.
  • Upgrade softwind to support pool.GetFullCap.

@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 10, 2023

Test result:
image

dae-prow[bot]
dae-prow bot approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@mzz2017 mzz2017 merged commit 1cc9edc into main Jul 10, 2023
@mzz2017 mzz2017 deleted the fix_truncated_dns branch July 10, 2023 17:25
@mzz2017 mzz2017 mentioned this pull request Jul 11, 2023
Merged
3 tasks
@piyoki piyoki mentioned this pull request Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dae-prow dae-prow[bot] dae-prow[bot] approved these changes

Assignees

@mzz2017 mzz2017

Labels
fix tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mzz2017