Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to bind to lan lazily and re-bind to lan #166

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented Jun 30, 2023

Background

Sometimes, we want to bind a LAN interface once it is brought up (NewLink).

For example, I want to bind dae to ap0 once I start to share my hotspot. However, I do not exactly know when in the future I will start to share my hotspot and create an ap0. dae will fail to start if fail to bind any LAN interfaces.

图片

Another problem is that if my ap0 is deleted, when ap0 is created in the future, dae will not bind to it again.

This PR fixes it.

Checklist

Full changelogs

  • If fail to bind due to link not found, wait for RTM_NEWLINK and bind to it.
  • If a link is deleted, wait for RTM_NEWLINK and bind to it.

@mzz2017 mzz2017 changed the title feat: support to bind and re-bind lan lazily feat: support to bind to and re-bind to lan lazily Jun 30, 2023
@dae-prow
Copy link
Contributor

dae-prow bot commented Jun 30, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

@mzz2017 mzz2017 changed the title feat: support to bind to and re-bind to lan lazily feat: support to bind to lan lazily and re-bind to lan Jun 30, 2023
@mzz2017
Copy link
Contributor Author

mzz2017 commented Jul 7, 2023

This was tested by CTO.

Copy link
Contributor

@dae-prow dae-prow bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 Since the PR has been fully tested, please consider merging it.

@piyoki
Copy link
Contributor

piyoki commented Jul 7, 2023

@mzz2017 Cool, let’s merge it.

@mzz2017 mzz2017 merged commit c708e0e into main Jul 7, 2023
@mzz2017 mzz2017 deleted the feat_support_lazy_bind_lan branch July 7, 2023 09:35
@mzz2017 mzz2017 mentioned this pull request Jul 8, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants