Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): domain_matcher/benchmark_test.go #107

Merged
merged 1 commit into from
May 30, 2023
Merged

fix(test): domain_matcher/benchmark_test.go #107

merged 1 commit into from
May 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented May 30, 2023

Background

component/routing/domain_matcher/benchmark_test.go panic due to nil pointer.

Checklist

  • The Pull Request has been fully tested

@ghost ghost requested a review from mzz2017 as a code owner May 30, 2023 14:41
@mzz2017 mzz2017 closed this May 30, 2023
@mzz2017 mzz2017 deleted the fix_domain_matcher_benchmark branch May 30, 2023 14:42
@mzz2017 mzz2017 restored the fix_domain_matcher_benchmark branch May 30, 2023 14:47
@mzz2017 mzz2017 reopened this May 30, 2023
@mzz2017 mzz2017 merged commit 46ee320 into main May 30, 2023
@mzz2017 mzz2017 deleted the fix_domain_matcher_benchmark branch May 30, 2023 14:48
@piyoki piyoki added the test label Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzz2017 mzz2017

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzz2017 @piyoki