Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rand seed for network check #106

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

mzz2017
Copy link
Contributor

@mzz2017 mzz2017 commented May 30, 2023

Background

Every time check network using following list, it always performs in solid order.

dae/cmd/run.go

Lines 36 to 40 in 2a8f8f9

CheckNetworkLinks = []string{
"http://edge.microsoft.com/captiveportal/generate_204",
"http://www.gstatic.com/generate_204",
"http://www.qualcomm.cn/generate_204",
}

Checklist

  • The Pull Request has been fully tested

Full changelog

  • Replace rand with fastrand, which uses seed in its init func.

@piyoki piyoki added the enhancement New feature or request label May 30, 2023
@mzz2017 mzz2017 merged commit 689fa0f into main May 30, 2023
@mzz2017 mzz2017 deleted the fix_fake_rand_checknetwork branch May 30, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants