Create Go Related Workflows in Github Actions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
force-pushed
the
github-actions
branch
10 times, most recently
from
55328bb to
ffd6c7d
Compare
|
Noting we need to commit go.sum file for the lint to pass. Reasoning https://github.com/golang/go/wiki/Modules#releasing-modules-all-versions |
daemon1024
force-pushed
the
github-actions
branch
7 times, most recently
from
32ff5b9 to
628a334
Compare
daemon1024
force-pushed
the
github-actions
branch
6 times, most recently
from
6115b75 to
8569c66
Compare
daemon1024
force-pushed
the
github-actions
branch
from
8569c66 to
3fabe5c
Compare
daemon1024
force-pushed
the
github-actions
branch
5 times, most recently
from
4aca549 to
2ccd153
Compare
daemon1024
force-pushed
the
github-actions
branch
from
2ccd153 to
052a694
Compare
daemon1024
pushed a commit
that referenced
this pull request
Jun 20, 2022
honor controller failback logic
daemon1024
pushed a commit
that referenced
this pull request
Jul 3, 2023
…ory and fix to pass the tests The current implementation does not have a job in CI to run tests for golang programs under the KubeArmor/KubeArmor directory. Therefore, this commit will add the job to ci-test-go.yml to run tests for golang programs under the KubeArmor/KubeArmor directory. On the other hand, in the current implementation, the following error occurs when go test is executed in the directory KubeArmor/KubeArmor/core. > go test # github.com/kubearmor/KubeArmor/KubeArmor/core ./karmorprobedata.go:61:3: (*github.com/kubearmor/KubeArmor/KubeArmor/feeder.Feeder).Errf format %s reads arg #1, but call has 0 args Thus, if test_kubearmor.sh or go test ./... on the kubearmor/kubeArmor are run, the test will fail. The test fails because dm.Logger.Errf(), which is called in the SetKarmorData function in the file core/karmorprobedata.go, is missing an argument for the format specifier. Therefore, this commit will fix it to add a variable for the format specifiers so that the test will succeed properly. Signed-off-by: Hayato Kiwata <[email protected]>
Aryan-sharma11
pushed a commit
that referenced
this pull request
Aug 2, 2023
…ory and fix to pass the tests The current implementation does not have a job in CI to run tests for golang programs under the KubeArmor/KubeArmor directory. Therefore, this commit will add the job to ci-test-go.yml to run tests for golang programs under the KubeArmor/KubeArmor directory. On the other hand, in the current implementation, the following error occurs when go test is executed in the directory KubeArmor/KubeArmor/core. > go test # github.com/kubearmor/KubeArmor/KubeArmor/core ./karmorprobedata.go:61:3: (*github.com/kubearmor/KubeArmor/KubeArmor/feeder.Feeder).Errf format %s reads arg #1, but call has 0 args Thus, if test_kubearmor.sh or go test ./... on the kubearmor/kubeArmor are run, the test will fail. The test fails because dm.Logger.Errf(), which is called in the SetKarmorData function in the file core/karmorprobedata.go, is missing an argument for the format specifier. Therefore, this commit will fix it to add a variable for the format specifiers so that the test will succeed properly. Signed-off-by: Hayato Kiwata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.