fix: shifted kcs are not mod tappable without overrides

daedric · Nov 22, 2024 · 7d80f01 · 7d80f01
1 parent d1d5144
commit 7d80f01
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/keyboards/zsa/moonlander/keymaps/daedric_34/config.h b/keyboards/zsa/moonlander/keymaps/daedric_34/config.h
@@ -29,11 +29,6 @@
 // keyboard does not wake up properly after suspending
 
 #define USB_SUSPEND_WAKEUP_DELAY 0
-
-#define TRI_LAYER_LOWER_LAYER 4
-#define TRI_LAYER_UPPER_LAYER 5
-#define TRI_LAYER_ADJUST_LAYER 7
-
 /* Set by Oryx to their default value:
  * https://github.com/qmk/qmk_firmware/blob/a4da5f219fe0f202a07afa045fc0c08f6ce1f86b/docs/features/rawhid.md#basic-configuration-basic-configuration
  */

diff --git a/keyboards/zsa/moonlander/keymaps/daedric_34/keymap.c b/keyboards/zsa/moonlander/keymaps/daedric_34/keymap.c
@@ -348,7 +348,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
 
             _______    ,     _______    ,     _______    ,     _______    ,     _______    ,     _______    ,     _______    ,               _______    ,     _______    ,     _______    ,     _______    ,     _______    ,     _______    ,     _______    ,
             _______    ,     KC_CIRC    ,      KC_LT     ,      KC_GT     ,     KC_DLR     ,     KC_PERC    ,     _______    ,               _______    ,      KC_AT     ,     KC_AMPR    ,     KC_ASTR    ,     KC_QUOT    ,     KC_GRV     ,     _______    ,
-            _______    ,     KC_LCBR    , LALT_T(KC_LPRN), LCTL_T(KC_RPRN), LSFT_T(KC_RCBR), LGUI_T(KC_EQL) ,     _______    ,               _______    , LGUI_T(KC_BSLS), LSFT_T(KC_PLUS), LCTL_T(KC_MINS), LALT_T(KC_SLSH),     KC_DQT     ,     _______    ,
+            _______    ,     KC_LCBR    ,     KC_LPRN    ,     KC_RPRN    ,     KC_RCBR    ,     KC_EQL     ,     _______    ,               _______    , LGUI_T(KC_BSLS), LSFT_T(KC_PLUS), LCTL_T(KC_MINS), LALT_T(KC_SLSH),     KC_DQT     ,     _______    ,
             _______    ,     KC_TILD    ,     KC_LBRC    ,     KC_RBRC    ,     KC_UNDS    ,     KC_HASH    ,                       KC_PIPE    ,     KC_EXLM    ,     KC_SCLN    ,     KC_COLN    ,     KC_QUES    ,     _______    ,
             _______    ,     _______    ,     _______    ,     _______    ,     _______    ,             _______    ,         _______    ,           _______    ,     _______    ,     _______    ,     _______    ,     _______    ,
                                 _______    ,     _______    ,     _______    ,         _______    ,     _______    ,     _______

diff --git a/scripts/gen_keymap.py b/scripts/gen_keymap.py
@@ -1011,7 +1011,9 @@ def gen(self):
         Mode.SymQwerty: """
         _______, _______, _______, _______, _______, _______, _______,            _______, _______, _______, _______, _______, _______, _______,
         _______, KC_CIRC,  KC_LT ,  KC_GT , KC_DLR , KC_PERC, _______,            _______,  KC_AT , KC_AMPR, KC_ASTR, KC_QUOT, KC_GRV , _______,
-        _______, KC_LCBR,LALT_T(KC_LPRN),LCTL_T(KC_RPRN),LSFT_T(KC_RCBR),LGUI_T(KC_EQL), _______,            _______, LGUI_T(KC_BSLS), LSFT_T(KC_PLUS), LCTL_T(KC_MINS), LALT_T(KC_SLSH), KC_DQT , _______,
+        _______, KC_LCBR, KC_LPRN,KC_RPRN , KC_RCBR,  KC_EQL, _______,            _______, LGUI_T(KC_BSLS), LSFT_T(KC_PLUS), LCTL_T(KC_MINS), LALT_T(KC_SLSH), KC_DQT , _______,
+        // does not work because those kc are shifted version, I need to implement an overide
+        // _______, KC_LCBR,LALT_T(KC_LPRN),LCTL_T(KC_RPRN),LSFT_T(KC_RCBR),LGUI_T(KC_EQL), _______,            _______, LGUI_T(KC_BSLS), LSFT_T(KC_PLUS), LCTL_T(KC_MINS), LALT_T(KC_SLSH), KC_DQT , _______,
         _______, KC_TILD, KC_LBRC, KC_RBRC, KC_UNDS, KC_HASH,                              KC_PIPE, KC_EXLM, KC_SCLN, KC_COLN, KC_QUES, _______,
         _______, _______, _______, _______, _______,          _______,            _______,          _______, _______, _______, _______, _______,
                                             _______, _______, _______,            _______, _______, _______