Use _doc doc type instead of doc #581
Conversation
![sonarqubecloud[bot]](https://avatars.githubusercontent.com/in/12526?s=60&v=4){kind=small}
| * @deprecated Will be removed with Elasticsearch V8 | ||
| */ | ||
| @Deprecated | ||
| private static final String INDEX_TYPE_DOC = "_doc"; |
There was a problem hiding this comment.
|
|
||
| // With elasticsearch 6.x, we can use _doc as the default type name | ||
| if (VERSION.onOrAfter(Version.V_6_0_0)) { | ||
| logger.debug("Using elasticsearch >= 6, so we can use {} as the default type name", defaultTypeName); |
There was a problem hiding this comment.
| logger.debug("Using elasticsearch >= 6, so we can use {} as the default type name", defaultTypeName); | ||
| } else { | ||
| defaultTypeName = INDEX_TYPE_DOC_V5; | ||
| logger.debug("Using elasticsearch < 6, so we use {} as the default type name", defaultTypeName); |
There was a problem hiding this comment.
| * @deprecated Will be removed with Elasticsearch V8 | ||
| */ | ||
| @Deprecated | ||
| private String defaultTypeName = INDEX_TYPE_DOC; |
There was a problem hiding this comment.
| if (VERSION.onOrAfter(Version.V_6_0_0)) { | ||
| logger.debug("Using elasticsearch >= 6, so we can use {} as the default type name", defaultTypeName); | ||
| } else { | ||
| defaultTypeName = INDEX_TYPE_DOC_V5; |
There was a problem hiding this comment.
| if (VERSION.onOrAfter(Version.V_6_0_0)) { | ||
| logger.debug("Using elasticsearch >= 6, so we can use {} as the default type name", defaultTypeName); | ||
| } else { | ||
| defaultTypeName = INDEX_TYPE_DOC_V5; |
There was a problem hiding this comment.
| * @deprecated Will be removed with Elasticsearch V8 | ||
| */ | ||
| @Deprecated | ||
| private static final String INDEX_TYPE_DOC_V5 = "doc"; |
There was a problem hiding this comment.
| @@ -291,6 +317,10 @@ public Version getVersion() { | |||
| return VERSION; | |||
| } | |||
|
|
|||
| public String getDefaultTypeName() { | |||
| return defaultTypeName; | |||
There was a problem hiding this comment.
Closes #552.