Add File Permissions to generated documents #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadoonet
changed the title
Note: this does not work on Windows.
This is adding File Permissions as their octal representation (`740` for example) when `attributes_support` is set to `true`.
Example of a generated document:
```json
{
"file":{
"filename":"test.odt",
"extension":"odt",
"last_modified":1386855978000,
"indexing_date":"2013-12-12T13:50:58.758Z",
"content_type":"application/vnd.oasis.opendocument.text",
"url":"file:///tmp/testfs_metadata/test.odt",
"indexed_chars":100000,
"filesize":8355,
"checksum":"c32eafae2587bef4b3b32f73743c3c61"
},
"path":{
"root":"bceb3913f6d793e915beb70a4735592",
"virtual":"/test.odt",
"real":"/tmp/testfs_metadata/test.odt"
},
"attributes": {
"owner": "david",
"group": "staff",
"permissions": 764
},
"meta":{
"author":"David Pilato",
"title":"Mon titre",
"date":"2013-04-04T15:21:35",
"keywords":[
"fs",
"elasticsearch",
"crawler"
],
"language":"fr"
},
"content":"Bonjour David\n\n\n"
}
```
Closes #559.
So we have a better code and SonarCloud is happy :)
dadoonet
force-pushed
the
pr/add-posix-permissions
branch
from
9e91a19 to
988d929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add File Permissions to generated documents
Note: this does not work on Windows.
This is adding File Permissions as their octal representation (
740for example) whenattributes_supportis set totrue.Example of a generated document:
{ "file":{ "filename":"test.odt", "extension":"odt", "last_modified":1386855978000, "indexing_date":"2013-12-12T13:50:58.758Z", "content_type":"application/vnd.oasis.opendocument.text", "url":"file:///tmp/testfs_metadata/test.odt", "indexed_chars":100000, "filesize":8355, "checksum":"c32eafae2587bef4b3b32f73743c3c61" }, "path":{ "root":"bceb3913f6d793e915beb70a4735592", "virtual":"/test.odt", "real":"/tmp/testfs_metadata/test.odt" }, "attributes": { "owner": "david", "group": "staff", "permissions": 764 }, "meta":{ "author":"David Pilato", "title":"Mon titre", "date":"2013-04-04T15:21:35", "keywords":[ "fs", "elasticsearch", "crawler" ], "language":"fr" }, "content":"Bonjour David\n\n\n" }Closes #559.