Move to Docker based integration tests #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly we have to run now our tests sequentially If we move the Docker start as a Maven pre-integration process we will be able to run that again in parallel. Closes #496.
It's not available as a Docker image.
It's not available as a Docker image.
dadoonet
added a commit
that referenced
this pull request
Feb 19, 2018
With recent changes like #500 and #514 it takes much more time to run all tests from the IDE when elasticsearch is not running yet locally. The reason is that we start a new elasticsearch test container for every class. Starting a container can take some time. We should try to reduce that and share the same docker instance for all tests. Closes #516
dadoonet
added a commit
that referenced
this pull request
Feb 19, 2018
With recent changes like #500 and #514 it takes much more time to run all tests from the IDE when elasticsearch is not running yet locally. The reason is that we start a new elasticsearch test container for every class. Starting a container can take some time. We should try to reduce that and share the same docker instance for all tests. Closes #516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly we have to run now our tests sequentially
If we move the Docker start as a Maven pre-integration process we will be able to run that again in parallel.
Closes #496.