Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use our own Http Client and remove specific distributions #1376

Merged
merged 30 commits into from
Feb 25, 2022
Merged

Use our own Http Client and remove specific distributions #1376

merged 30 commits into from
Feb 25, 2022

Conversation

dadoonet
Copy link
Owner

@dadoonet dadoonet commented Feb 7, 2022 •
edited
Loading

With this PR we want to:

  • Use a generic and simple Elasticsearch Client
  • The client can be used with whatever version of Elasticsearch 6.x, 7.x, 8.x
  • We won't need anymore multiple distributions per major version of Elasticsearch
  • We check anytime we are executing an HTTP call that the connection was successful and if not, instead of failing we are trying against the next nodes.

@dadoonet dadoonet added the update When updating an existing feature label Feb 7, 2022
@dadoonet dadoonet added this to the 2.10 milestone Feb 7, 2022
@dadoonet dadoonet self-assigned this Feb 7, 2022
@lgtm-com
Copy link

lgtm-com bot commented Feb 7, 2022

This pull request fixes 2 alerts when merging 84014f6 into 96ae262 - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@lgtm-com
Copy link

lgtm-com bot commented Feb 10, 2022

This pull request fixes 2 alerts when merging 17fa12f into 0b8c8ab - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@dadoonet
Use getVersion() to check if Workplace Search is running
5e4d021
@dadoonet
Fix Workplace Search Client tests
92495ee
@dadoonet
Fix Workplace Search integration tests
9600343 
Also make sure that we don't run the delete existing documents as it's not supported yet by FSCrawler.
@lgtm-com
Copy link

lgtm-com bot commented Feb 11, 2022

This pull request fixes 2 alerts when merging 9600343 into 0b8c8ab - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2022

This pull request fixes 2 alerts when merging 74044d0 into 0b8c8ab - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@lgtm-com
Copy link

lgtm-com bot commented Feb 12, 2022

This pull request fixes 2 alerts when merging 7a4d305 into c9f3122 - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@iadcode iadcode mentioned this pull request Feb 14, 2022
Merged
@lgtm-com
Copy link

lgtm-com bot commented Feb 23, 2022

This pull request fixes 2 alerts when merging cfe6be8 into 6b7681e - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@dadoonet dadoonet mentioned this pull request Feb 25, 2022
Closed
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request fixes 2 alerts when merging 4cd61ea into 6b7681e - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request fixes 2 alerts when merging 8df0e52 into 6b7681e - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@dadoonet dadoonet marked this pull request as ready for review February 25, 2022 07:16
@dadoonet dadoonet merged commit ebb6f58 into master Feb 25, 2022
@dadoonet dadoonet deleted the new-http-client branch February 25, 2022 07:18
@lgtm-com
Copy link

lgtm-com bot commented Feb 25, 2022

This pull request fixes 2 alerts when merging 434f788 into 6b7681e - view on LGTM.com

fixed alerts:

  • 2 for `TrustManager` that accepts all certificates

@dadoonet dadoonet mentioned this pull request Feb 25, 2022
Closed
This was linked to issues Feb 25, 2022
Support for opensearch/opendistro #1274
Closed
Reopen Elasticsearch connection after a long idle time #1264
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dadoonet dadoonet

Labels
Release Highlight update When updating an existing feature
Projects
None yet
Milestone
2.10
Development

Successfully merging this pull request may close these issues.

Support for opensearch/opendistro Reopen Elasticsearch connection after a long idle time
1 participant
@dadoonet