Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latest docker tag should be only the latest stable version #1227

Closed
dadoonet opened this issue Aug 5, 2021 · 0 comments · Fixed by #1228
Closed

latest docker tag should be only the latest stable version #1227

dadoonet opened this issue Aug 5, 2021 · 0 comments · Fixed by #1228
Assignees
@dadoonet

Comments

@dadoonet
Copy link
Owner

dadoonet commented Aug 5, 2021

When pulling the default docker image dadoonet/fscrawler, we are actually getting the latest build, which means the latest SNAPSHOT version.

docker pull dadoonet/fscrawler

Instead we should have a latest tag only for released versions so today latest should be dadoonet/fscrawler:2.7.
@dadoonet dadoonet added this to the 2.8 milestone Aug 5, 2021
@dadoonet dadoonet self-assigned this Aug 5, 2021
dadoonet added a commit that referenced this issue Aug 5, 2021
@dadoonet
latest docker tag should be only the latest stable version
aaccb4d 
When pulling the default docker image `dadoonet/fscrawler`, we are actually getting the latest build, which means the latest SNAPSHOT version.

```sh
docker pull dadoonet/fscrawler
```

With this change, we are making sure that we only use the `latest` tag when doing the release.

People can still get the latest SNAPSHOT version by running:

```sh
docker pull dadoonet/fscrawler:2.8-SNAPSHOT
```

Closes #1227
@dadoonet dadoonet mentioned this issue Aug 5, 2021
Merged
@dadoonet dadoonet removed this from the 2.8 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dadoonet dadoonet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

latest docker tag should be only the latest stable version dadoonet/fscrawler
1 participant
@dadoonet