Skip to content

Commit

Permalink
Fix the deploy phase
Browse files Browse the repository at this point in the history
We had 3 times the same plugin and deploy did not deploy to dockerhub because the configuration was overwritten.
  • Loading branch information
dadoonet committed Apr 23, 2021
1 parent 2140533 commit 691ddf1
Showing 1 changed file with 0 additions and 106 deletions.
106 changes: 0 additions & 106 deletions distribution/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -224,112 +224,6 @@
</execution>
</executions>
</plugin>
<!-- Generate the docker images (run during package step) -->
<plugin>
<groupId>io.fabric8</groupId>
<artifactId>docker-maven-plugin</artifactId>
<configuration>
<!-- Disable configuration for IT -->
<images combine.self="override">
<image>
<external>
<type>properties</type>
<prefix>docker.nolang</prefix>
</external>
</image>
<image>
<external>
<type>properties</type>
<prefix>docker.eng</prefix>
</external>
</image>
<image>
<external>
<type>properties</type>
<prefix>docker.fra</prefix>
</external>
</image>
<image>
<external>
<type>properties</type>
<prefix>docker.jpn</prefix>
</external>
</image>
</images>
</configuration>
<executions>
<execution>
<id>docker-build</id>
<phase>package</phase>
<goals>
<goal>build</goal>
</goals>
</execution>
<execution>
<!-- There is no integration test so we can skip that execution -->
<id>start-elasticsearch</id>
<phase>none</phase>
</execution>
<execution>
<!-- There is no integration test so we can skip that execution -->
<id>stop-elasticsearch</id>
<phase>none</phase>
</execution>
</executions>
</plugin>
<!-- Generate the docker images (run during package step) -->
<plugin>
<groupId>io.fabric8</groupId>
<artifactId>docker-maven-plugin</artifactId>
<configuration>
<!-- Disable configuration for IT -->
<images combine.self="override">
<image>
<external>
<type>properties</type>
<prefix>docker.nolang</prefix>
</external>
</image>
<image>
<external>
<type>properties</type>
<prefix>docker.eng</prefix>
</external>
</image>
<image>
<external>
<type>properties</type>
<prefix>docker.fra</prefix>
</external>
</image>
<image>
<external>
<type>properties</type>
<prefix>docker.jpn</prefix>
</external>
</image>
</images>
</configuration>
<executions>
<execution>
<id>docker-build</id>
<phase>package</phase>
<goals>
<goal>build</goal>
</goals>
</execution>
<execution>
<!-- There is no integration test so we can skip that execution -->
<id>start-elasticsearch</id>
<phase>none</phase>
</execution>
<execution>
<!-- There is no integration test so we can skip that execution -->
<id>stop-elasticsearch</id>
<phase>none</phase>
</execution>
</executions>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down

0 comments on commit 691ddf1

Please sign in to comment.