fixing bug

daddyz · Sep 17, 2017 · 41c7821 · 41c7821
1 parent e6aee78
commit 41c7821
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## Upcoming Changes (unreleased)
 
-## 0.6.14 - September 17, 2017
+## 0.6.15 - September 17, 2017
 - updated data
 - ```:extensions``` option added to validator, once set to ```false``` will perform additional check if parsed phone has extension
 

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    phonelib (0.6.14)
+    phonelib (0.6.15)
 
 GEM
   remote: http://rubygems.org/

diff --git a/lib/phonelib/version.rb b/lib/phonelib/version.rb
@@ -1,4 +1,4 @@
 module Phonelib
   # @private
-  VERSION = '0.6.14'
+  VERSION = '0.6.15'
 end
diff --git a/lib/validators/phone_validator.rb b/lib/validators/phone_validator.rb
@@ -51,7 +51,7 @@ class PhoneValidator < ActiveModel::EachValidator
   # Validation method
   def validate_each(record, attribute, value)
     return if options[:allow_blank] && value.blank?
-    options[:extensions] ||= true
+    allowed_extensions = options.has_key?(:extensions) ? options[:extensions] : true
 
     phone = parse(value, specified_country(record))
     valid = if simple_validation?
@@ -61,7 +61,7 @@ def validate_each(record, attribute, value)
             end
 
     # We default to not-allowing extensions for fax numbers
-    if valid && options[:extensions] === false && !phone.extension.empty?
+    if valid && !allowed_extensions && !phone.extension.empty?
       valid = false
     end