Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Swift Package Manager #7

Merged
merged 2 commits into from
May 15, 2023
Merged

Support Swift Package Manager #7

merged 2 commits into from
May 15, 2023

Conversation

pabloruan0710
Copy link
Contributor

  • Add support SPM
  • Add support SwiftUI
  • Build in Xcode 14.2

dadalar
dadalar requested changes May 13, 2023
View reviewed changes
Copy link
Owner

@dadalar dadalar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for your PR, it looks really good! I made a few minor comments .

Sources/DDSpiderChart/Classes/DDSpiderChartSwiftUI.swift Outdated Show resolved Hide resolved
Sources/DDSpiderChart/Classes/DDSpiderChartSwiftUI.swift Outdated Show resolved Hide resolved
Example/Pods/Local Podspecs/DDSpiderChart.podspec.json Outdated Show resolved Hide resolved
Example/Pods/Local Podspecs/DDSpiderChart.podspec.json Outdated Show resolved Hide resolved
DDSpiderChart.podspec Outdated Show resolved Hide resolved
@pabloruan0710 pabloruan0710 requested a review from dadalar May 13, 2023 21:28
@dadalar dadalar merged commit 9bc65be into dadalar:master May 15, 2023
@dadalar
Copy link
Owner

dadalar commented May 15, 2023

Thanks again! I've now merged this PR and release a 0.6 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadalar dadalar dadalar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pabloruan0710 @dadalar