Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a new mode to draw area polygons snapped to roads! https://gith… #26

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

dabreegster
Copy link
Owner

…ub.com/acteng/atip/issues/118

screencast.mp4

Here's a working area drawing tool that snaps to roads! It's a bit clunky, but I'm happy with it as a v1. I'll followup with a PR in ATIP to integrate it.

Some of the unsolved bugs / design warts:

  • No attempt to "backfill" or import an existing polygon produced in another tool. You can edit a polygon made with this tool only.
  • No freehand points at all in this mode. We can relax this constraint later, but it gets tricky. For now, I'm picturing two separate polygon tools in ATIP -- the current freehand one and this one. Won't be able to mix and match yet.
  • You can delete waypoints by clicking them, unless it happens to be the first waypoint, which is a bit special internally.
  • Sometimes a waypoint winds up looking like a linear route that doubles back on itself; the resulting polygon is a bit broken. The user can visually avoid this; it's obvious when it goes wrong.
  • After drawing a closed polygon, I've sometimes clicked and managed to incorrectly insert a new waypoint at the very end, creating a linestring that escapes the polygon. This is incorrect / a bug. I can't repro yet; I'll click more carefully in future tests. :)

CC @robinlovelace-ate and @Sparrow0hawk. Async code review always welcome

@dabreegster dabreegster merged commit a14e601 into main Apr 27, 2023
@dabreegster dabreegster deleted the cordon_v2 branch April 27, 2023 11:25
@robinlovelace-ate
Copy link

This is absolutely amazing 🤯

Will be useful for designing areal interventions in Design mode, in addition to planning. Great work Dustin 👏 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants