Fix column computation in documentation #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The column computation function in the documentation had a few problems:
input
parameter, but it's actuallytext
.last_cr
ends up at the newline character, except at the first line.With respect to the second item, I hacked a quick test (attached), which also incudes the fixed version.
I tried to make the function as small as possible so I deleted the
if
statement, so the function now relies onrfind
returning-1
if it failed to find a new-line. Not sure if you like that, however it is documented functionality: https://docs.python.org/3/library/stdtypes.html?highlight=str%20rfind#str.rfind so should be quite stable behaviour.t.py.txt