Fix an error on Windows when no sockets are being select()'d #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… would raise a WindowsError (WSAEINVAL) on Windows.
|
Need more information about this pull request. To my knowledge, curio doesn't even poll sockets if there are no tasks listening. So, I'm a bit confused about the circumstances under which this might arise. I could be missing something though. |
|
Closing this because the code has shifted a fair bit since it was first reported. Should note that I am open to future pull-requests related to Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This won't call select() if there are no sockets being checked, as on Windows this will raise a WindowsError(WSAEINVAL)