Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added page title in twitter social share button #112

Closed
wants to merge 1 commit into from
Closed

added page title in twitter social share button #112

wants to merge 1 commit into from

Conversation

DirectorX
Copy link
Contributor

No description provided.

@daattali
Copy link
Owner

daattali commented Oct 8, 2016

Thank you, but I'm pretty sure this will break sharing. The Twitter one might work, but the others require a URL and by adding some text to the URL field it'll break

@daattali daattali closed this Oct 8, 2016
@DirectorX
Copy link
Contributor Author

@daattali works well
have a look here

@daattali
Copy link
Owner

daattali commented Oct 8, 2016

Clicking the Twitter share link on that page works for me. Clicking the Facebook/Linked In links do not work for me.

@DirectorX
Copy link
Contributor Author

right, i should add {{ url_param_escape }}

@daattali
Copy link
Owner

daattali commented Oct 8, 2016

if you get it working on a different page, do let me know

@DirectorX
Copy link
Contributor Author

after a little research seems like tweeter are the only one that allow it

@daattali
Copy link
Owner

daattali commented Oct 8, 2016

Right, that makes sense, because for Twitter you're telling it what to include in the "tweet" text, whereas the other sites are asking for a URL specifically , not free form text

@DirectorX DirectorX changed the title added page titles in social share buttons added page title in twitter social share button Oct 8, 2016
@DirectorX
Copy link
Contributor Author

DirectorX commented Oct 8, 2016

i did git commit --amend and rewrote the history, now the commit is 2c062bc, please reopen this issue and review the changes.

@daattali
Copy link
Owner

daattali commented Oct 8, 2016

This PR cannot be re-opened. Can you please submit a new pull request with the new changes

Moeby added a commit to Moeby/mobydq.github.io that referenced this pull request Oct 17, 2018
Moeby added a commit to Moeby/mobydq.github.io that referenced this pull request Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants