-
-
Notifications
You must be signed in to change notification settings - Fork 16.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added page title in twitter social share button #112
Conversation
Thank you, but I'm pretty sure this will break sharing. The Twitter one might work, but the others require a URL and by adding some text to the URL field it'll break |
Clicking the Twitter share link on that page works for me. Clicking the Facebook/Linked In links do not work for me. |
right, i should add |
if you get it working on a different page, do let me know |
after a little research seems like tweeter are the only one that allow it |
Right, that makes sense, because for Twitter you're telling it what to include in the "tweet" text, whereas the other sites are asking for a URL specifically , not free form text |
i did |
This PR cannot be re-opened. Can you please submit a new pull request with the new changes |
No description provided.