Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few issues reported by a reddit user #4

Closed
daattali opened this issue Apr 4, 2015 · 1 comment
Closed

A few issues reported by a reddit user #4

daattali opened this issue Apr 4, 2015 · 1 comment

Comments

@daattali
Copy link
Owner

daattali commented Apr 4, 2015

There are some issues though:

  • It looks like site.baseurl support is somewhat lacking. I've seen several places where it's not used. Check the output of grep 'site\.url[^-]' -rn . | grep -v baseurl. All of the lines it finds are broken when you have a baseurl.
  • On hosts that don't auto-redirect "foo" to "foo/" (they exist), removing "/index.html" is a bit too aggressive, remove "index.html" instead. (in head.html)
    • For the same reason, be sure to link to {{site.url}}{{base.url}}/ (including the slash) when linking to the base URL itself.
  • For some reason, some of the footer icons don't show up properly here. RSS and LinkedIn are the ones I've noticed, but there might be others. I'm not sure why, so I've just disabled those on my site.

I fixed some of those issues on my site, but because there are too many unrelated changes mixed in I don't feel like cleaning it up and submitting a pull request, sorry.

@daattali
Copy link
Owner Author

all these issues have been resolved or are were never actually broken

spalanco pushed a commit to rycuma/rycuma.github.io that referenced this issue Mar 22, 2016
spalanco pushed a commit to rycuma/rycuma.github.io that referenced this issue Mar 28, 2016
daattali pushed a commit that referenced this issue Sep 3, 2016
dmferrari referenced this issue in stoneacre/supermonedero Apr 28, 2017
dayvsonlima pushed a commit to phoenix-cli/phoenix-cli.github.io that referenced this issue Jul 22, 2017
dayvsonlima pushed a commit to phoenix-cli/phoenix-cli.github.io that referenced this issue Jul 22, 2017
mindlab-skku pushed a commit to mindlab-skku/mindlab-skku.github.io that referenced this issue Mar 19, 2018
csjzhou pushed a commit to csjzhou/csjzhou_backup.github.io that referenced this issue Apr 1, 2018
dugmo pushed a commit to dugmo/dugmo.github.io that referenced this issue Jul 11, 2018
hongquan95 pushed a commit to hongquan95/hongquan95.github.io that referenced this issue May 2, 2019
akhiljalan pushed a commit to akhiljalan/akhiljalan-github-io-old-version that referenced this issue Jun 9, 2019
scottspace added a commit to scottspace/scottspace.github.io that referenced this issue Aug 12, 2019
GitNick88 added a commit to GitNick88/GitNick88.github.io that referenced this issue Jan 9, 2020
shanerodrigues added a commit to shanerodrigues/shanerodrigues.github.io that referenced this issue Jan 24, 2020
scerioli pushed a commit to scerioli/play-with-beautiful-jekyll that referenced this issue Jun 13, 2021
…-11e9-beb4-d1f35c904fc1

New comment by Vincent Tam
Snowdeaf added a commit to Snowdeaf/snowdeaf.github.io that referenced this issue Jan 6, 2023
sjpark2free added a commit to sjpark2free/sjpark2free.github.io that referenced this issue Nov 2, 2024
sjpark2free added a commit to sjpark2free/sjpark2free.github.io that referenced this issue Nov 5, 2024
aaravamin15 pushed a commit to aaravamin15/aaravamin15.github.io that referenced this issue Dec 3, 2024
aaravamin15 pushed a commit to aaravamin15/aaravamin15.github.io that referenced this issue Dec 3, 2024
aaravamin15 pushed a commit to aaravamin15/aaravamin15.github.io that referenced this issue Dec 3, 2024
aaravamin15 pushed a commit to aaravamin15/aaravamin15.github.io that referenced this issue Dec 3, 2024
alexander-huynh pushed a commit to alexander-huynh/alexander-huynh.github.io that referenced this issue Dec 19, 2024
Ignore the _site/ directory for local builds.
alexander-huynh pushed a commit to alexander-huynh/alexander-huynh.github.io that referenced this issue Dec 19, 2024
TravisBAO added a commit to TravisBAO/travisbao.github.io that referenced this issue Dec 20, 2024
aaravamin15 pushed a commit to aaravamin15/aaravamin15.github.io that referenced this issue Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant